New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix behaviour of async PythonParser to match RedisParser as for issue #2349 #2582
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2582 +/- ##
==========================================
+ Coverage 60.38% 60.42% +0.04%
==========================================
Files 115 115
Lines 29725 29750 +25
==========================================
+ Hits 17949 17977 +28
+ Misses 11776 11773 -3
... and 25 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
|
7505e52
to
dff4f82
Compare
Some of our tests are quite finnicky, sensitive to timeouts occurring which can always happein in a virtualized backend. |
@kristjanvalur Can you resolve the conflicts? |
Pull Request check-list
Please make sure to review and check all of these items:
$ tox
pass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
PR #2557 we allowed the async
HiredisParser
to finish reading a response even while a concurrentdisconnect()
might be issued. This PR enables the test, and duplicates the behaviour for thePythonParser
.