Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behaviour of async PythonParser to match RedisParser as for issue #2349 #2582

merged 5 commits into from Mar 16, 2023


Copy link

@kristjanvalur kristjanvalur commented Feb 7, 2023

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

PR #2557 we allowed the async HiredisParser to finish reading a response even while a concurrent disconnect() might be issued. This PR enables the test, and duplicates the behaviour for the PythonParser.

Copy link

codecov-commenter commented Feb 7, 2023

Codecov Report

Patch coverage: 81.81% and project coverage change: +0.04 🎉

Comparison is base (7d474f9) 60.38% compared to head (07c2c1d) 60.42%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2582      +/-   ##
+ Coverage   60.38%   60.42%   +0.04%     
  Files         115      115              
  Lines       29725    29750      +25     
+ Hits        17949    17977      +28     
+ Misses      11776    11773       -3     
Impacted Files Coverage Δ
tests/test_asyncio/ 39.35% <ø> (+0.50%) ⬆️
redis/asyncio/ 81.67% <81.81%> (ø)

... and 25 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kristjanvalur kristjanvalur marked this pull request as ready for review February 8, 2023 07:43
Copy link
Contributor Author

Some of our tests are quite finnicky, sensitive to timeouts occurring which can always happein in a virtualized backend.

@dvora-h dvora-h added the bug Bug label Mar 16, 2023
Copy link

dvora-h commented Mar 16, 2023

@kristjanvalur Can you resolve the conflicts?

@dvora-h dvora-h merged commit 1b2f408 into redis:master Mar 16, 2023
46 checks passed
@kristjanvalur kristjanvalur deleted the kristjan/2349.2 branch March 16, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
bug Bug
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants