Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CredentialsProvider examples #2587

merged 2 commits into from Mar 15, 2023


Copy link

@barshaul barshaul commented Feb 9, 2023

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

The last two examples of credential providers are incorrect and use an old design that we haven't chosen. Fixed the examples.

Copy link

codecov-commenter commented Feb 26, 2023

Codecov Report

Base: 92.31% // Head: 92.26% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (51b5e76) compared to base (6c708c2).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2587      +/-   ##
- Coverage   92.31%   92.26%   -0.06%     
  Files         115      115              
  Lines       29744    29744              
- Hits        27459    27444      -15     
- Misses       2285     2300      +15     
Impacted Files Coverage Δ
tests/ 84.94% <0.00%> (-0.78%) ⬇️
tests/test_asyncio/ 98.29% <0.00%> (-0.35%) ⬇️
redis/asyncio/ 91.68% <0.00%> (-0.33%) ⬇️
tests/ 96.64% <0.00%> (-0.33%) ⬇️
tests/test_asyncio/ 99.37% <0.00%> (-0.16%) ⬇️
tests/test_asyncio/ 97.48% <0.00%> (-0.13%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Feb 26, 2023
@dvora-h dvora-h merged commit 3edd49b into redis:master Mar 15, 2023
40 checks passed
aksinha334 pushed a commit to aksinha334/redis-py that referenced this pull request Mar 15, 2023
Co-authored-by: dvora-h <>
dvora-h added a commit that referenced this pull request Mar 15, 2023
* Fixed issue #2598 - make Document class subscriptable

* Last time added older file, fixed it

* retrigger checks

* update json().arrindex() default values (#2611)

* update json().arrindex() default values

* add unit test

* fix falsy checks

* more unit tests

* add asyncio tests

* fix lint line length


Co-authored-by: Alex Schmitz <>

* Speeding up the protocol parsing (#2596)

* speeding up the protocol parser

* linting

* changes to ease

* Fixed CredentialsProvider examples (#2587)

Co-authored-by: dvora-h <>

* ConnectionPool SSL example (#2605)

* [types] update return type of smismember to list[int] (#2617)

* update return type of smismember

* use Literal instead of int

* retrigger checks

* Added test for document subscriptable in tests/

* Fixed linter issue

* retrigger checks


Co-authored-by: Alex Schmitz <>
Co-authored-by: Alex Schmitz <>
Co-authored-by: Chayim <>
Co-authored-by: Bar Shaul <>
Co-authored-by: dvora-h <>
Co-authored-by: CrimsonGlory <>
Co-authored-by: Raymond Yin <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
maintenance Maintenance (CI, Releases, etc)
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants