/ redis-py Public
introduce AbstractConnection so that UnixDomainSocketConnection can call super().__init__ #2588
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
Pull Request check-list
Please make sure to review and check all of these items:
$ toxpass with this change (including linting)?
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Motivation: changes to
Connection.__init__are easily forgotten to be applied also to
UnixDomainSocketConnection.__init__(for example #2570 and #2377) which leads to issues like #2581.
Before this MR
After this MR