New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can I help? #752

Closed
mperham opened this Issue May 18, 2018 · 11 comments

Comments

Projects
None yet
7 participants
@mperham
Contributor

mperham commented May 18, 2018

Looks like this repo is struggling with support. I would be happy to provide some maintenance / support for issues/PRs. Interested?

@djanowski

This comment has been minimized.

Member

djanowski commented May 18, 2018

I understand @badboy added more collaborators recently. What's the status of that, Jan-Erik?

@badboy

This comment has been minimized.

Member

badboy commented May 18, 2018

I haven't done so! Will do that on the weekend.

@badboy

This comment has been minimized.

Member

badboy commented May 22, 2018

I just added a bunch of Shopify folks as admins to this repo (through the redis-rb team):

@fw42
@sirupsen
@rafaelfranca
@dylanahsmith
@csfrancis
@byroot

I will also add them as collaborators on hiredis-rb and to Rubygems.

Please coordinate ongoing work, don't remove folks and keep hacking!

@fw42

This comment has been minimized.

fw42 commented May 22, 2018

Danke Jan-Erik!

@byroot

This comment has been minimized.

Member

byroot commented May 22, 2018

Thanks @badboy, we'll do our best.

However if @mperham propose to step in, I think he would be very helpful person for this repo (if not more than us shopifolks).

@tubbo

This comment has been minimized.

tubbo commented Aug 8, 2018

I can also help, currently maintaining the redis-store gems and I've seen more than one place where some collaboration between us could really clean up some ugly code. will continue to monitor issues and contribute where I can.

@whatl3y

This comment has been minimized.

whatl3y commented Aug 8, 2018

In addition to better support, I would love the latest updates be published to rubygems. I struggled for a while on trying to get the SSLContext verify_mode == VERIFY_NONE since I was connecting via the redis server's IP address, but realized after hours of trying, asking a stack overflow question, and opening a forum discussion in AWS with little help that the commit I needed wasn't up yet: 25f1f70

I am working around this by updating by Gemfile to be the following, but for obvious reasons would like to avoid this if possible in the future:

gem "redis", :git => 'git://github.com/redis/redis-rb'

@byroot

This comment has been minimized.

Member

byroot commented Aug 8, 2018

I would love the latest updates be published to rubygems.

I'd love to as well, unfortunately I still don't have publish access on rubygems. I was traveling the last few week, but I'll try to get them.

@badboy if you ear us I'd love to push a new version out

Also cc @fw42

@byroot

This comment has been minimized.

Member

byroot commented Aug 9, 2018

@tubbo I don't have the access to add you as members, however don't let this prevent you from submitting PRs. I will very happily review them, and can commit to timely reviews and merges for PRs coming from you.

That obviously also applies to @mperham.

@badboy

This comment has been minimized.

Member

badboy commented Aug 9, 2018

Oh, I didn't do that yet? I'm sorry about that. Giving you access in the next hour.

@badboy

This comment has been minimized.

Member

badboy commented Aug 9, 2018

And it's done (added the list of emails I got a while back from @fw42). Thanks for maintaining this and sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment