allow for configuration keys with nil values to fall back onto defaults #627
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our effort to turn our deployment into something 12-factor-compliant, we tried to base our configuration solely on ENV variables like so:
This however results in the configuration hash holding several unnecessary keys with
nil
values. Thus these changes are needed so in case of a key existing but being nil, the default is still used.I assume this was intended all along, but did only work for some of the keys, not all.