Increase redisvl test coverage #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
+ Coverage 78.92% 80.62% +1.69%
==========================================
Files 25 25
Lines 1476 1476
==========================================
+ Hits 1165 1190 +25
+ Misses 311 286 -25 ☔ View full report in Codecov by Sentry. |
Collaborator
tylerhutcherson
left a comment
tylerhutcherson
left a comment
There was a problem hiding this comment.
Looks solid! I left a few comments. We'll get this merged today.
bsbodden
force-pushed
the
bsb/tests_and_minor_fixes
branch
from
29b89d6 to
dfad9d3
Compare
tylerhutcherson
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upped the coverage to 81% and fix a minor bug in the utils