Skip to content

Fix vectorizer tests and docstrings #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Fix vectorizer tests and docstrings #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion redisvl/utils/vectorize/text/cohere.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class CohereTextVectorizer(BaseVectorizer):
)
doc_embeddings = cohere.embed_many(
texts=["your document text", "more document text"],
input_type="search_documents"
input_type="search_document"
)

"""
Expand Down
7 changes: 5 additions & 2 deletions tests/integration/test_vectorizers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,10 @@ def vectorizer(request):
@pytest.mark.skipif(skip_vectorizer_test, reason="Skipping vectorizer tests")
def test_vectorizer_embed(vectorizer):
text = "This is a test sentence."
embedding = vectorizer.embed(text)
if isinstance(vectorizer, CohereTextVectorizer):
embedding = vectorizer.embed(text, input_type="search_document")
else:
embedding = vectorizer.embed(text)

assert isinstance(embedding, list)
assert len(embedding) == vectorizer.dims
Expand Down Expand Up @@ -77,7 +80,7 @@ def test_vectorizer_bad_input(vectorizer):


@pytest.fixture(params=[OpenAITextVectorizer])
def avectorizer(request, openai_key):
def avectorizer(request):
# Here we use actual models for integration test
if request.param == OpenAITextVectorizer:
return request.param()
Expand Down