Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions redisvl/utils/log.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import logging
import sys


def get_logger(name, log_level="info", fmt=None):
Expand All @@ -10,13 +9,7 @@ def get_logger(name, log_level="info", fmt=None):

logger = logging.getLogger(name)

# Only configure this specific logger, not the root logger
# Check if the logger already has handlers to respect existing configuration
# Add a NullHandler to loggers to avoid "no handler found" warnings
if not logger.handlers:
logging.basicConfig(
level=logging.INFO,
format="%(asctime)s %(name)s %(levelname)s %(message)s",
datefmt="%H:%M:%S",
stream=sys.stdout,
)
logger.addHandler(logging.NullHandler())
return logger
7 changes: 2 additions & 5 deletions tests/unit/logger_interference_checker.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,10 @@
)
)

# Configure root logger
root_logger = logging.getLogger()
root_logger.handlers = [handler]
root_logger.setLevel(logging.INFO)

# Log before import
app_logger = logging.getLogger("app")
app_logger.setLevel(logging.INFO)
app_logger.addHandler(handler)
app_logger.info("PRE_IMPORT_FORMAT")

# Import RedisVL
Expand Down
16 changes: 10 additions & 6 deletions tests/unit/test_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -489,18 +489,22 @@ def test_logging_configuration_not_overridden(self):

# Extract the log lines
output_lines = result.stdout.strip().split("\n")
pre_import_line = ""
post_import_line = ""
pre_import_lines = []
post_import_lines = []

for line in output_lines:
if "PRE_IMPORT_FORMAT" in line:
pre_import_line = line
pre_import_lines.append(line)
elif "POST_IMPORT_FORMAT" in line:
post_import_line = line
post_import_lines.append(line)

# Check if we found both lines
assert pre_import_line, "No pre-import log message found"
assert post_import_line, "No post-import log message found"
assert pre_import_lines, "No pre-import log message(s) found"
assert post_import_lines, "No post-import log message(s) found"
assert len(pre_import_lines) == 1, "Multiple pre-import log messages found"
assert len(post_import_lines) == 1, "Multiple post-import log messages found"
pre_import_line = pre_import_lines[0]
post_import_line = post_import_lines[0]

# Print for debugging
print(f"Pre-import format: {pre_import_line}")
Expand Down