Use SOURCE_DATE_EPOCH over unreproducible uname + date calls. #2992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See <https://reproducible-builds.org/specs/source-date-epoch/> for more details. Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
lamby
force-pushed
the
source-date-epoch
branch
from
4a0b32a
to
82ae4f3
Compare
|
Updated. |
|
@reproduciblebuilds are really a bigger deal these days - any chance of getting this merged? :) |
|
I'd love to drop this @Debian-specific patch. Can you help? This changes no behaviour unless you export |
|
That's a good idea, thank you, merged. I would appreciate a few line of documentation about this in the README.md file otherwise is basically hidden for everybody not knowing it directly. |
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Dec 17, 2018
Use SOURCE_DATE_EPOCH over unreproducible uname + date calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
See https://reproducible-builds.org/specs/source-date-epoch/ for more
details.
Signed-off-by: Chris Lamb chris@chris-lamb.co.uk