feat: Migrate to math/rand/v2 #553
Conversation
|
Please have a look @rueian ^_^ |
internal/util/rand.go
Outdated
| return | ||
| } | ||
|
|
||
| func BinaryString() []byte { |
There was a problem hiding this comment.
On self-review, we could probably rename this
Open to suggestions
internal/util/rand.1.22.go
Outdated
| rand.Shuffle(n, swap) | ||
| } | ||
|
|
||
| func IntN(n int) int { |
There was a problem hiding this comment.
until.IntN looks vague. I think we can just replace it with the below FastRand.
There was a problem hiding this comment.
We can do that, but for go !1.22
The regular usage of Intn would also be replaced with rngPool implementation, Should we do that? @rueian
|
Addressed @rueian Pls take a look |
om/json.go
Outdated
| @@ -3,6 +3,7 @@ package om | |||
| import ( | |||
| "context" | |||
| "encoding/json" | |||
| "github.com/oklog/ulid/v2" | |||
rueidis.go
Outdated
| @@ -7,8 +7,8 @@ import ( | |||
| "context" | |||
| "crypto/tls" | |||
| "errors" | |||
| "github.com/redis/rueidis/internal/util" | |||
| "errors" | ||
| "math/rand" | ||
| "github.com/redis/rueidis/internal/util" | ||
| "strconv" |
sentinel.go
Outdated
| @@ -5,15 +5,14 @@ import ( | |||
| "context" | |||
| "errors" | |||
| "fmt" | |||
| "github.com/redis/rueidis/internal/util" | |||
|
@rueian Done, I guess this sorting should be okay |
Hi @SoulPancake, #554 has been merged. Could you rebase this PR? |
update master
|
Done @rueian |
|
@rueian Is this ready to be merged? |
|
Yes, this will be merged this weekend. |
|
Thanks @SoulPancake! |
Solves