Conversation
added 19 commits
March 9, 2021 14:24
joeriddles
reviewed
Oct 19, 2021
joeriddles
left a comment
There was a problem hiding this comment.
Hello, coming from your blog post about FastAPI 👋
The FastAPI refactor looks pretty good to me. I agree that FastAPI's way of authentication leaves a bit to be desired.
| docs = transform_documents(docs, search_site, q.query_string()) | ||
| resp.body = json.dumps({"total": total, "results": docs}) | ||
| from_url = from_url if from_url else '' | ||
| start = start if isinstance(start, int) else 0 |
There was a problem hiding this comment.
Is isinstance necessary here, since start has a type hint of Optional[int]? FastAPI uses Pydantic under the hood, which will attempt to coerce anything passed-in to the function to an int.
pydantic uses int(v) to coerce types to an int; see this warning on loss of information during data conversion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite the search API to use fastapi and aioredis-py.
Current benchmarks:
FastAPI
Falcon