Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis INFO call stopped working after 3.7.1 release #1480

Closed
ericwu1 opened this issue Jun 11, 2018 · 1 comment
Closed

Redis INFO call stopped working after 3.7.1 release #1480

ericwu1 opened this issue Jun 11, 2018 · 1 comment
Labels
bug
Milestone

Comments

@ericwu1
Copy link

@ericwu1 ericwu1 commented Jun 11, 2018

Expected behavior

Call Redis INFO on a given node in a cluster and it should return a blob of info for that given node.

Actual behavior

When the redisson client is preparing to send the redis INFO call, client2key returns null for the given redisClient which only happened to me during INFO calls, not any writes or reads. This is the commit that I believe caused this behavior. fe98d0a#diff-bb90b8f5c06abce59014861b02cecd93

06/04/2018 16:18:59 PDT DEBUG redisson-netty-1-4 ClusterConnectionManager:391 - cluster nodes state from 10.73.128.146/10.73.128.146:6379:
03de98146f0038a9a04587dd6ef102f48c54aeab 10.73.128.76:6379 slave 0cba7b1e954e4235a9ac86e0306608e97e04e404 0 1528154338964 98 connected
0cba7b1e954e4235a9ac86e0306608e97e04e404 10.73.128.146:6379 myself,master - 0 0 98 connected 10922-16383
117b100e765b5af972dd7d3f96b9541d7c7aba24 10.73.128.138:6379 slave a3e0502ebb14d9b6c4eb0d600e05e15d30adb387 0 1528154337463 79 connected
d78a886e8fb890bb98ed740f8908b222874a164a 10.73.129.85:6379 slave 178153b9fdc7b8314ef3a26f269395d4ec6597ca 0 1528154338464 93 connected
987c581e9b11b72d9e17c4e58d8c66abce653dd6 10.73.128.93:6379 slave 0cba7b1e954e4235a9ac86e0306608e97e04e404 0 1528154337963 98 connected
178153b9fdc7b8314ef3a26f269395d4ec6597ca 10.73.128.68:6379 master - 0 1528154336962 93 connected 5461-10921
a3e0502ebb14d9b6c4eb0d600e05e15d30adb387 10.73.128.91:6379 master - 0 1528154337463 79 connected 0-5460


org.redisson.client.RedisConnectionException: Can't find entry for [addr=redis://10.73.128.68:6379]
    at org.redisson.connection.balancer.LoadBalancerManager.getConnection(LoadBalancerManager.java:241)
    at org.redisson.connection.MasterSlaveEntry.connectionReadOp(MasterSlaveEntry.java:507)
    at org.redisson.connection.MasterSlaveConnectionManager.connectionReadOp(MasterSlaveConnectionManager.java:583)
    at org.redisson.command.CommandAsyncService.async(CommandAsyncService.java:497)
    at org.redisson.command.CommandAsyncService$8.run(CommandAsyncService.java:589)
    at io.netty.util.HashedWheelTimer$HashedWheelTimeout.expire(HashedWheelTimer.java:668)
    at io.netty.util.HashedWheelTimer$HashedWheelBucket.expireTimeouts(HashedWheelTimer.java:743)
    at io.netty.util.HashedWheelTimer$Worker.run(HashedWheelTimer.java:471)
    at java.lang.Thread.run(Thread.java:745)
Can't find entry for [addr=redis://10.73.128.68:6379]

It seems the issue is the hashcodes are different only when making the INFO call (That i know of) because the channels value changes.

So when doing the get for client2key, it gets nothing. For Writes and reads that i tried, the hashcodes for the clients are the same

Steps to reproduce or test case

Spin up any redis cluster and simply call .info() on a node in the .getNodesGroup()

Redis version

3.2.11

Redisson version

3.7.1

Redisson configuration

default redis cluster config with 7 nodes in the cluster. 3 Master and 4 Slave

@mrniko mrniko added this to the 2.12.2 milestone Jun 12, 2018
@mrniko mrniko added the bug label Jun 13, 2018
mrniko pushed a commit that referenced this issue Jun 13, 2018
@mrniko

This comment has been minimized.

Copy link
Member

@mrniko mrniko commented Jun 13, 2018

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.