New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transactions support #43

Closed
mrniko opened this Issue Jul 17, 2014 · 8 comments

Comments

4 participants
@mrniko
Member

mrniko commented Jul 17, 2014

No description provided.

@mrniko mrniko added the feature label Jul 17, 2014

@mrniko mrniko changed the title from Transaction support to Transactions support Jul 17, 2014

@mrniko mrniko added this to the 1.3 milestone Jul 20, 2014

@mrniko mrniko modified the milestones: 1.2.1, 1.2.2 Mar 14, 2015

@mrniko mrniko modified the milestone: 2.0.0 Jul 9, 2015

@michelbetancourt

This comment has been minimized.

michelbetancourt commented Jun 15, 2016

Hi, Since this has been open for some time now, I am curious to know if this is actively being worked or if this is just a feature that is being considered?

@jackygurui

This comment has been minimized.

Member

jackygurui commented Jun 16, 2016

@michelbetancourt If you are referring the feature to using Watch/Multi/Exec commands. I am afraid this is considered (close) to be depreciated by redis. It is discouraged by the redis author.

You can use RLock to mimic the transaction behaviour and you will get much better performance. @mrniko has recently removed the last remaining internal usage of these commands and observed up to 400% performance gain. 4fcd54e

I can't see this feature been actually implemented any time in the near future, in my opinion.

@ittaiz

This comment has been minimized.

ittaiz commented Sep 12, 2017

How do you get performance gain when going from pessimistic locking (RLock) to optimistic locking (Watch)? Assuming you have rare collisions

@jackygurui

This comment has been minimized.

Member

jackygurui commented Sep 12, 2017

In rare collision case, performance gain came from reduced network round trip.

@ittaiz

This comment has been minimized.

ittaiz commented Sep 12, 2017

Thanks for replying!
Don't you have similar network round trips when using RLock (lock/unlock)?

@jackygurui

This comment has been minimized.

Member

jackygurui commented Sep 12, 2017

When use Lua script, the network round trip happens only once, and considering how fast redis is, network round trips can be the bottleneck for performance.

@ittaiz

This comment has been minimized.

ittaiz commented Sep 12, 2017

I see. I read the above command as moving to programatic RLock in jvm code and not to Lua script. I now understand.
Thanks!

@jackygurui

This comment has been minimized.

Member

jackygurui commented Feb 6, 2018

Superseded with #1242

@jackygurui jackygurui closed this Feb 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment