Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Chosen would fail when being applied to a disabled <select> #1

Merged
merged 1 commit into from Mar 29, 2014

Conversation

Projects
None yet
2 participants

Calling this.selected_item_focus_handle.remove() only makes sense if this.selected_item_focus_handle exists in the first place. The if statement on line 774 had this logic backwards.

This error:
screen shot 2014-03-26 at 3 05 04 pm
would appear when applying Chosen to a disabled select element.

Simply removing the ! fixed it right up.

@simmerer simmerer fixed incorrect negation
Calling this.selected_item_focus_handle.remove() only makes sense if this.selected_item_focus_handle exists in the first place.
1bdbaa0

@simmerer simmerer changed the title from fixed incorrect negation to Chosen would fail when being applied to a disabled <select> Mar 26, 2014

@redking redking added a commit that referenced this pull request Mar 29, 2014

@redking redking Merge pull request #1 from simmerdesign/master
Chosen would fail when being applied to a disabled <select>
735143f

@redking redking merged commit 735143f into redking:master Mar 29, 2014

Owner

redking commented Mar 29, 2014

Thanks! This would have been an issue with the master, as I just converted the code to AMD, with a few changes. I plan to pull in upstream changes shortly and then give the code a good look over + unit tests; should avoid most issues like this.

Thanks again!

Happy to help. Thanks for all your work so far on this project - it's been very useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment