Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change bash dependency to sh #9

Closed
wants to merge 1 commit into from
Closed

Conversation

polygon
Copy link

@polygon polygon commented Oct 23, 2018

I was having some issues using ppsfind on an embedded system where no Bash shell was included since the shebang in the file is #!/bin/bash. I've found that the script does not use any bash specific features so I suggest changing the shebang to #!/bin/sh.

@gerasiov
Copy link

Nice try, but I'd better rewrite it a little bit, since it has many problems with unquoted $1 etc.

Will you be able to do some minimal test with the folowing version?
7203700

@polygon
Copy link
Author

polygon commented Oct 24, 2018

That's even better. Attached is a quick log of some testing. Looks good so far. Here is the system I tested on, unfortunately, my devices do not have anything in the path so I can't test for that.

# uname -a
Linux xlarray 4.14.0-xlarray #12 SMP PREEMPT Wed Oct 24 11:57:34 CEST 2018 aarch64 GNU/Linux
# ls -l /bin/sh
lrwxrwxrwx    1 root     root             7 Sep  7 12:47 /bin/sh -> busybox
# ls /sys/class/pps/
pps0  pps1  pps2  pps3
# ls /sys/class/pps/*/name
/sys/class/pps/pps0/name  /sys/class/pps/pps1/name  /sys/class/pps/pps2/name  /sys/class/pps/pps3/name
# cat /sys/class/pps/*/name
pll_pps.-1
ptp0
ptp1
ptp2
# cat /sys/class/pps/*/path




#

And the test:

# ./ppsfind pll
pps0: name=pll_pps.-1 path=
# ./ppsfind ptp
pps1: name=ptp0 path=
pps2: name=ptp1 path=
pps3: name=ptp2 path=
# ./ppsfind ptp1
pps2: name=ptp1 path=

@gerasiov
Copy link

Ok, merged #10 in

@gerasiov gerasiov closed this Oct 26, 2018
@gerasiov
Copy link

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants