Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for bash #60

Merged
merged 1 commit into from Aug 8, 2017
Merged

Add recipe for bash #60

merged 1 commit into from Aug 8, 2017

Conversation

ids1024
Copy link
Contributor

@ids1024 ids1024 commented Aug 8, 2017

No description provided.

#include "common.h"
#include "bashgetopt.h"

-#include <shtty.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is a shtty?

:P

{
/* ttsave() */
termsave.fd = fd;
- ttgetattr (fd, &ttattrs);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We technically have termios now, it should probably be implemented in newlib

# include <unistd.h>
#endif

-#include <sys/ioctl.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have winsize, using a dup buffer

{
int e;

- if (setuid (current_user.uid) < 0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to use setuid

break;

case SIG_SETMASK:
- old = sigsetmask (new);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe sigblock and sigsetmask can be implemented in terms of sigaction?

@jackpot51
Copy link
Member

Merging for now, but I left comments

@jackpot51 jackpot51 merged commit 3faf975 into redox-os:master Aug 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants