Skip to content
This repository was archived by the owner on Apr 28, 2026. It is now read-only.

Add recipe for bash#60

Merged
jackpot51 merged 1 commit intoredox-os:masterfrom
ids1024:bash
Aug 8, 2017
Merged

Add recipe for bash#60
jackpot51 merged 1 commit intoredox-os:masterfrom
ids1024:bash

Conversation

@ids1024
Copy link
Copy Markdown
Contributor

@ids1024 ids1024 commented Aug 8, 2017

No description provided.

#include "common.h"
#include "bashgetopt.h"

-#include <shtty.h>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is a shtty?

:P

{
/* ttsave() */
termsave.fd = fd;
- ttgetattr (fd, &ttattrs);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We technically have termios now, it should probably be implemented in newlib

# include <unistd.h>
#endif

-#include <sys/ioctl.h>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have winsize, using a dup buffer

{
int e;

- if (setuid (current_user.uid) < 0)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to use setuid

break;

case SIG_SETMASK:
- old = sigsetmask (new);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe sigblock and sigsetmask can be implemented in terms of sigaction?

@jackpot51
Copy link
Copy Markdown
Member

Merging for now, but I left comments

@jackpot51 jackpot51 merged commit 3faf975 into redox-os:master Aug 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants