Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for issue #585 #659

Merged
merged 6 commits into from Dec 22, 2017

Conversation

@covercash2
Copy link
Contributor

commented Dec 22, 2017

Solution:

the level: u8 variable in the Iterator::next implementation for the ArgumentSplitter was being decremented when its value was 0, causing a panic (unsigned ints cannot be less than 0).

Changes introduced by this pull request

i assumed that level represented the depth of the parentheses, so i consolidated the handling of parentheses and added level +=1 or level -= 1 respectively.

i also refactored the raw bit flags to use the bitflags crate for a few reason:

  1. the crate was already imported
  2. it makes the code a lot more readable (to me at least)
  3. it helped me understand the code

Drawbacks

i just assumed level was referring to the parenthesis level, but i could be wrong. if that's the case this pull request should be rejected.

@mmstick

This comment has been minimized.

Copy link
Collaborator

commented Dec 22, 2017

Thanks!

@mmstick mmstick merged commit 31a737f into redox-os:master Dec 22, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.