Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make env: return ENOENT on non-existent; support unlink() #25

Merged
merged 1 commit into from Jun 20, 2017
Merged

Make env: return ENOENT on non-existent; support unlink() #25

merged 1 commit into from Jun 20, 2017

Conversation

@ids1024
Copy link
Member

@ids1024 ids1024 commented Jun 20, 2017

This also requires a small modification to libstd; I guess I'll submit a PR to redox-os/rust, and if it looks okay a PR can be sent upstream as well. Everything has to be rebuilt for this change, if it sets environmental variables. That seems unavoidable though.

Hopefully this is okay, but I don't know why that if condition was commented out, so perhaps it causes issues I'm not aware of.

@jackpot51
Copy link
Member

@jackpot51 jackpot51 commented Jun 20, 2017

Cool, we should see how it ends up working

@jackpot51 jackpot51 merged commit 0478e5f into redox-os:master Jun 20, 2017
bors added a commit to rust-lang/rust that referenced this pull request Jun 22, 2017
Redox: Use create() instead of open() when setting env variable

See redox-os/kernel#25.
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 22, 2017
Redox: Use create() instead of open() when setting env variable

See redox-os/kernel#25.
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 23, 2017
Redox: Use create() instead of open() when setting env variable

See redox-os/kernel#25.
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 23, 2017
Redox: Use create() instead of open() when setting env variable

See redox-os/kernel#25.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants