New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement getppid system call #26

Merged
merged 1 commit into from Jun 29, 2017

Conversation

Projects
None yet
2 participants
@ids1024
Member

ids1024 commented Jun 29, 2017

@jackpot51 jackpot51 merged commit a4c3afb into redox-os:master Jun 29, 2017

@ids1024

This comment has been minimized.

Member

ids1024 commented Jun 29, 2017

Oh, this make break the build since the kernel's Cargo.toml get's redox_syscall from crates.io. Should redox_syscall have a minor version bump?

Edit: Worse: it builds, but the match statement takes SYS_GETPPID as a variable matching any value, and ignores with warnings the cases after it. So it builds but is broken.

@jackpot51

This comment has been minimized.

Member

jackpot51 commented Jun 29, 2017

Yes, I will bump the package. We really need a strict requirement on syscall in the kernel

@ids1024 ids1024 deleted the ids1024:getppid branch Jul 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment