Pass empty second argument to dup() call in clone #27
Conversation
I don't know if this was there for a reason, but it was making the dup() fail with tcpd, and I don't seem this being handled specially in redoxfs or anywhere else.
|
Very cryptic. There is another place where dup flags are used with exec that should probably be blank |
|
I see: // Duplicate current files using b"exec", close previous
...Does that code even need to call dup and close, or could it just keep the file descriptors as is? |
|
It does need to dup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I don't know if this was there for a reason, but it was making the dup() fail with tcpd, and I don't seem this being handled specially in redoxfs or anywhere else.
This seems to have been the cause for one issue I was having with
git; it was somewhat cryptic since the actual call that was failing (the dup itself) wasn't listed in the log of the program's system calls, and I think earlier I missed the fact that the failing read was in another process that had forked.