New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass empty second argument to dup() call in clone #27

Merged
merged 1 commit into from Jul 6, 2017

Conversation

Projects
None yet
2 participants
@ids1024
Member

ids1024 commented Jul 6, 2017

I don't know if this was there for a reason, but it was making the dup() fail with tcpd, and I don't seem this being handled specially in redoxfs or anywhere else.

This seems to have been the cause for one issue I was having with git; it was somewhat cryptic since the actual call that was failing (the dup itself) wasn't listed in the log of the program's system calls, and I think earlier I missed the fact that the failing read was in another process that had forked.

Pass empty second argument to dup() call in clone
I don't know if this was there for a reason, but it was making the dup()
fail with tcpd, and I don't seem this being handled specially in redoxfs
or anywhere else.
@jackpot51

This comment has been minimized.

Member

jackpot51 commented Jul 6, 2017

Very cryptic. There is another place where dup flags are used with exec that should probably be blank

@jackpot51 jackpot51 merged commit d0c3a5d into redox-os:master Jul 6, 2017

@ids1024 ids1024 deleted the ids1024:clone branch Jul 6, 2017

@ids1024

This comment has been minimized.

Member

ids1024 commented Jul 6, 2017

I see:

// Duplicate current files using b"exec", close previous
...

Does that code even need to call dup and close, or could it just keep the file descriptors as is?

@jackpot51

This comment has been minimized.

Member

jackpot51 commented Jul 6, 2017

It does need to dup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment