Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ping utility #21

Merged
merged 3 commits into from Jun 13, 2017

Conversation

@batonius
Copy link
Member

commented Jun 13, 2017

Problem: Redox doesn't have the ping utility.

Solution: Introduce the ping utility with minimal required features.

Changes introduced by this pull request:

  • The ping utility has been added.
  • The utility close follows the behavior of the ping utility from iputils.
  • The utility supports both IPv4 and host name destinations.
  • The utility supports -h, -c and -i options.
  • The utility doesn't require root privileges, suid bit or raw_net capability.
  • Several instances of the utility are able to work in parallel without interfering.

Drawbacks:

  • The utility has no access to the TTL field of the response packet.
  • Without the -c argument ping sends requests indefinitely and can't be interrupted with Ctrl-C. It provides no signal handlers and should be terminated on SIGINT, I suppose it has something to do with the current implementations of signals in Redox.

State: Redox has ping utility with the traditional behavior.

Other: This PR requires redox-os/netstack#1.

@batonius batonius referenced this pull request Jun 13, 2017
@jackpot51

This comment has been minimized.

Copy link
Member

commented Jun 13, 2017

I like it a lot!

@jackpot51 jackpot51 merged commit 205837f into redox-os:master Jun 13, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.