Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pbr crate for progress bar #11

Merged
merged 1 commit into from Jun 19, 2017
Merged

Use pbr crate for progress bar #11

merged 1 commit into from Jun 19, 2017

Conversation

@ids1024
Copy link
Member

@ids1024 ids1024 commented Jun 19, 2017

pkg-pb

I had to patch pbr with a termion based backend for Redox (ids1024/pb@3434f11). I had to subtract 1 from the column count to make it display on one line (the cursor ended up on the next line, messing things up). That shouldn't be necessary, but I'm not sure where the issue is (orbterm, termion, etc).

@jackpot51
Copy link
Member

@jackpot51 jackpot51 commented Jun 19, 2017

Cool!

@jackpot51 jackpot51 merged commit 0c3769f into redox-os:master Jun 19, 2017
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@ids1024
Copy link
Member Author

@ids1024 ids1024 commented Jun 19, 2017

@jackpot51 Do you know why I had to subtract one from the width to make it work correctly, as mentioned above? (Or the cursor ended up on the next line, resulting in the progress bar repeatedly printing on new lines, as is typical of these kinds of issues).

@jackpot51
Copy link
Member

@jackpot51 jackpot51 commented Jun 19, 2017

No, I am not sure. Termion should return what is in $COLUMNS, to check if that is correct you can echo $COLUMNS in a 640x480 virtual terminal, which should be 640/8

@ids1024
Copy link
Member Author

@ids1024 ids1024 commented Jun 19, 2017

columns

Printing $COLUNMNS characters seems to result in an extra blank line; presumably an orbterm bug.

@jackpot51
Copy link
Member

@jackpot51 jackpot51 commented Jun 19, 2017

It is a ransid bug

@ids1024
Copy link
Member Author

@ids1024 ids1024 commented Jun 19, 2017

Yeah, I'm looking at ransid now; I think I've found the cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.