Use pbr crate for progress bar #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! |
|
@jackpot51 Do you know why I had to subtract one from the width to make it work correctly, as mentioned above? (Or the cursor ended up on the next line, resulting in the progress bar repeatedly printing on new lines, as is typical of these kinds of issues). |
|
No, I am not sure. Termion should return what is in $COLUMNS, to check if that is correct you can echo $COLUMNS in a 640x480 virtual terminal, which should be 640/8 |
|
Printing $COLUNMNS characters seems to result in an extra blank line; presumably an orbterm bug. |
|
It is a ransid bug |
|
Yeah, I'm looking at ransid now; I think I've found the cause. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I had to patch pbr with a termion based backend for Redox (ids1024/pb@3434f11). I had to subtract 1 from the column count to make it display on one line (the cursor ended up on the next line, messing things up). That shouldn't be necessary, but I'm not sure where the issue is (orbterm, termion, etc).