Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUse pbr crate for progress bar #11
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Cool! |
jackpot51
merged commit 0c3769f
into
redox-os:master
Jun 19, 2017
1 check failed
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ids1024
Jun 19, 2017
Member
@jackpot51 Do you know why I had to subtract one from the width to make it work correctly, as mentioned above? (Or the cursor ended up on the next line, resulting in the progress bar repeatedly printing on new lines, as is typical of these kinds of issues).
|
@jackpot51 Do you know why I had to subtract one from the width to make it work correctly, as mentioned above? (Or the cursor ended up on the next line, resulting in the progress bar repeatedly printing on new lines, as is typical of these kinds of issues). |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jackpot51
Jun 19, 2017
Member
No, I am not sure. Termion should return what is in $COLUMNS, to check if that is correct you can echo $COLUMNS in a 640x480 virtual terminal, which should be 640/8
|
No, I am not sure. Termion should return what is in $COLUMNS, to check if that is correct you can echo $COLUMNS in a 640x480 virtual terminal, which should be 640/8 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ids1024
Jun 19, 2017
Member
Printing $COLUNMNS characters seems to result in an extra blank line; presumably an orbterm bug.
|
Printing $COLUNMNS characters seems to result in an extra blank line; presumably an orbterm bug. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
It is a ransid bug |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Yeah, I'm looking at ransid now; I think I've found the cause. |
ids1024 commentedJun 19, 2017
I had to patch pbr with a termion based backend for Redox (ids1024/pb@3434f11). I had to subtract 1 from the column count to make it display on one line (the cursor ended up on the next line, messing things up). That shouldn't be necessary, but I'm not sure where the issue is (orbterm, termion, etc).