[WIP] Symlinks#18
Merged
jackpot51 merged 2 commits intoredox-os:masterfrom Jun 29, 2017
ids1024:symlink
Merged
Conversation
Contributor
Author
|
For relative path handling, should the |
Member
|
Yes,probably so |
Contributor
Author
|
I've implemented relative symlinks; I think this is okay to merge now. I do think we want to support symlinks across schemes, but that will require some form of support in the scheme API, and I'm not sure how it should be done. |
Member
|
That's cool. I don't think symlinks across schemes are sensible yet, either |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are still some things to be resolved, but does this seem like a good way to implement it?
My idea is that instead of adding system calls (
symlinkandreadlink), symlinks can be opened with anO_SYMLINKflag to read where they point to, and created by opening with that flag and writing a path.A limitation of the current implementation is that it only works with symlinks to the same scheme, but I don't think that should be the case. How should that be handled? It could be useful to have some way for
open()to defer to another scheme.