Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sigaction() take Option<_> arguments #14

Merged
merged 1 commit into from Jul 11, 2017
Merged

Conversation

@ids1024
Copy link
Member

@ids1024 ids1024 commented Jul 11, 2017

It looks like the kernel handles null pointers correctly, but syscall doesn't provide a way to send them.

This is a breaking change, but that shouldn't be an issue since the API is new.

@ids1024
Copy link
Member Author

@ids1024 ids1024 commented Jul 11, 2017

An alternative would be to make the function take raw pointers, but that would mean it should be unsafe. Although, perhaps registering a signal handler is fairly unsafe anyway.

@jackpot51
Copy link
Member

@jackpot51 jackpot51 commented Jul 11, 2017

This is good

@jackpot51 jackpot51 merged commit 8e05a19 into redox-os:master Jul 11, 2017
@ids1024 ids1024 deleted the ids1024:sigaction branch Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants