Skip to content

Make sigaction() take Option<_> arguments#14

Merged
jackpot51 merged 1 commit intoredox-os:masterfrom
ids1024:sigaction
Jul 11, 2017
Merged

Make sigaction() take Option<_> arguments#14
jackpot51 merged 1 commit intoredox-os:masterfrom
ids1024:sigaction

Conversation

@ids1024
Copy link
Contributor

@ids1024 ids1024 commented Jul 11, 2017

It looks like the kernel handles null pointers correctly, but syscall doesn't provide a way to send them.

This is a breaking change, but that shouldn't be an issue since the API is new.

@ids1024
Copy link
Contributor Author

ids1024 commented Jul 11, 2017

An alternative would be to make the function take raw pointers, but that would mean it should be unsafe. Although, perhaps registering a signal handler is fairly unsafe anyway.

@jackpot51
Copy link
Member

This is good

@jackpot51 jackpot51 merged commit 8e05a19 into redox-os:master Jul 11, 2017
@ids1024 ids1024 deleted the sigaction branch July 11, 2017 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants