Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AsRef<[u8]> for paths, instead of &str #6

Merged
merged 1 commit into from May 30, 2017
Merged

Conversation

@ids1024
Copy link
Member

@ids1024 ids1024 commented May 8, 2017

As mentioned in redox-os/newlib#7.

This is a breaking change, since some things that implicitly convert to str will stop working (I noticed this in testing, since CStr.to_string_lossy() returns Cow<str>). I think that's unavoidable though.

@jackpot51
Copy link
Member

@jackpot51 jackpot51 commented May 8, 2017

Thanks! I will test this and then merge

@jackpot51 jackpot51 merged commit e4066a2 into redox-os:master May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants