Merge upstream #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In most cases, `tar` already wrote only `/` separators between path components. This is the only separator that works on Unix, and it's acceptable on Windows too. However, long paths in GNU headers were writing the full `path2bytes` result without translation, which meant Windows could write tar files with `\` that aren't portable to Unix. Now `path2bytes` will normalize all `\` to `/` on Windows. The new `path_separators` test makes sure that short and long paths with UStar and GNU headers will round-trip correctly, meaning the `path()` compares equal, while checking that `path_bytes()` doesn't contain `\` path separators. The long GNU path was writing `\` on Windows before.
Normalize all path separators to Unix-style `/`
…onsumers that don`t apply a umask at extraction time.
…c-mode Include file mode in items filtered for deterministic headers
This method lets one specify a manual header like `append`, but incorporates the special handling needed for setting long paths. If given path doesn't fit in the header `name`, it will write a GNU '././@LongLink' entry beforehand. Fixes alexcrichton#108. Fixes alexcrichton#109.
Add `Builder::append_data` supporting long paths
This commit fixes an unpacking failure triggered by hardlinks with relative link names. In such case, the source of the hard-link must be resolved first by nesting it under the unpacking directory.
entry: fix unpacking relative hardlinks
Unwrap returned Result in documentation for Builder
Should help when inspecting headers!
Fix xattr unit test
Add option to not follow symlinks
|
Thanks for this, it will be very useful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes changes I submitted to support symlinks.