Port to clap-rs #30
Merged
Port to clap-rs #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did a number of things here: the *add, *mod, and *del utilities, as well as id recieved substantial changes, probably what you'd call a rewrite. This was of course using clap-rs. These should all be very stable at this point (except unimplemented features in usermod, grr) getty, passwd, and su are simply ported, using clap for arg parsing. I didn't change any of the logic, just swapped ArgParser for clap. Fixed a bug with passwd and unset passwords I'll open issues about the ones I didn't mention.
|
This looks pretty good - I will merge |
|
Thanks! I mostly tested it. I will try to write a test suite sometime (must run on redox, as root probably), that way we can make sure everything works as expected all the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a number of things here:
the *add, *mod, and *del utilities, as well as id recieved substantial
changes, probably what you'd call a rewrite. This was of course using
clap-rs. These should all be very stable at this point (except
unimplemented features in usermod, grr)
getty, passwd, and su are simply ported, using clap for arg parsing. I
didn't change any of the logic, just swapped ArgParser for clap.
Fixed a bug with passwd and unset passwords
I'll open issues about the ones I didn't mention.
Solves #29