[v23.1.x] storage/record_batch_builder: Avoid intermediate std::vector
#11854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `= default` for destructor Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 8b1726e)
Move `add_raw_kv` definition to implementation file Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 030f8d5)
Some uses of `record_batch_builder` build very large batches, resulting in oversize allocations in `std::vector _records`. Remove the `std::vector` by serializing into an `iobuf` at the point of `add_raw_kv`. This requires storing an `int32_t` for the record count. Fixes redpanda-data#10744 Fixes redpanda-data#10749 Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 9c6e1ee)
BenPope
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #11837
Fixes: #11853,