Fix transaction visibility problem #3036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We control visibility of the transactions by using last_stable_offset() to set the maximum offset a reader may consume. See make_reader and log_reader_config::max_offset. Because last_stable_offset() returns supremum of the consumable offsets and make_reader expects maximum it led to an off by one error and made records of the aborted transactions visible. Fixing the issue by converting supremum to maximum. Fixes https://github.com/vectorizedio/support/issues/176
Adding a ducktape test to prevent regression in the future
rystsov
force-pushed
the
txs_visibility_fix
branch
from
f9bab16
to
dba62b1
Compare
dotnwat
approved these changes
Nov 20, 2021
dotnwat
approved these changes
Nov 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We control visibility of the transactions by using
last_stable_offset()to set the maximum offset a reader may consume. Seemake_readerandlog_reader_config::max_offset.Because
last_stable_offset()returns supremum of the consumable offsets and make_reader expects maximum it led to an off by one error and made records of the aborted transactions visible.Fixing the issue by converting supremum to maximum.
How was the fix tested?
Fixes https://github.com/vectorizedio/support/issues/176