Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpk: do not modify redpanda.rpc_server_tls field #7719

Merged
merged 3 commits into from Mar 10, 2023

Conversation

r-vasquez
Copy link
Contributor

@r-vasquez r-vasquez commented Dec 13, 2022

rpk now will treat this field like an unmanaged field, which means that we can have either a list, or an element, and rpk will respect that.

rpk will print a warning if the element is a list and will let the user know that TLS won't be enabled as it is.

Fixes #7644

Backports Required

  • v23.1.x
  • v22.3.x
  • v22.2.x

Release Notes

Bug Fixes

  • rpk will not modify redpanda.rpc_server_tls property when decoding the redpanda.yaml, which means that it will leave the field as a list or as an element depending on what the user has configured before executing rpk commands.

src/go/rpk/pkg/config/weak.go Outdated Show resolved Hide resolved
twmb
twmb previously approved these changes Dec 15, 2022
Copy link
Contributor

@twmb twmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's get documentation / a guide lined up before merging & releasing

@r-vasquez
Copy link
Contributor Author

Force Push:

Rebase with dev branch after 2 months.

@r-vasquez
Copy link
Contributor Author

Last force pushes introduced the ducktape tests: a9d3ea9

@r-vasquez r-vasquez requested a review from twmb March 2, 2023 14:56
src/go/rpk/pkg/config/weak.go Outdated Show resolved Hide resolved
rpk now will treat this field like an unmanaged
field, which means that we can have either a list,
or an element, and rpk will respect that.
These test cover normal scenarios that users
might face when migrating to this new version:

1. Enabling TLS from 0
2. Enabling TLS after a cluster is created
3. No knowing that they have the wrong TLS config
If the rpc_tls_server config is a list rpk will
do a TLS config validation and print a warning if
the config is invalid.
@twmb
Copy link
Contributor

twmb commented Mar 10, 2023

Failure is #9287, and the linters that we fixed.

@twmb twmb merged commit 6a69c28 into redpanda-data:dev Mar 10, 2023
26 of 29 checks passed
@twmb
Copy link
Contributor

twmb commented Mar 10, 2023

/backport v22.2.x

@vbotbuildovich
Copy link
Collaborator

Failed to run cherry-pick command. I executed the below command:

git cherry-pick -x e7e14aed624398a8b5b67f027534eed203136767 d99bad71447193e91e4f904facec99db9ac7d9c3 3dfa1d2d326ce0c02477c4650d0b761675524926

Workflow run logs.

@twmb
Copy link
Contributor

twmb commented Mar 10, 2023

/backport v22.3.x

@r-vasquez
Copy link
Contributor Author

/backport v23.1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rpk: do not modify input redpanda.rpc_server_tls field
3 participants