New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpk: do not modify redpanda.rpc_server_tls field #7719
Conversation
4e22f9b
to
90f1fb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's get documentation / a guide lined up before merging & releasing
90f1fb9
to
0feb1f0
Compare
|
Rebase with dev branch after 2 months. |
0feb1f0
to
f33d9cd
Compare
356ea26
to
a9d3ea9
Compare
|
Last force pushes introduced the ducktape tests: a9d3ea9 |
a9d3ea9
to
0349e9f
Compare
35feffb
to
8fda44c
Compare
rpk now will treat this field like an unmanaged field, which means that we can have either a list, or an element, and rpk will respect that.
These test cover normal scenarios that users might face when migrating to this new version: 1. Enabling TLS from 0 2. Enabling TLS after a cluster is created 3. No knowing that they have the wrong TLS config
If the rpc_tls_server config is a list rpk will do a TLS config validation and print a warning if the config is invalid.
8fda44c
to
3dfa1d2
Compare
|
Failure is #9287, and the linters that we fixed. |
|
/backport v22.2.x |
|
Failed to run cherry-pick command. I executed the below command: |
|
/backport v22.3.x |
|
/backport v23.1.x |
rpk now will treat this field like an unmanaged field, which means that we can have either a list, or an element, and rpk will respect that.
rpk will print a warning if the element is a list and will let the user know that TLS won't be enabled as it is.
Fixes #7644
Backports Required
Release Notes
Bug Fixes
redpanda.rpc_server_tlsproperty when decoding the redpanda.yaml, which means that it will leave the field as a list or as an element depending on what the user has configured before executing rpk commands.