New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpk: redact secret values when importing from file #8339
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM:
Could we have some unit tests for the output?
Should this be backported?
I found v22.1.x, v22.2.x and v22.3.x are affected
4987f39
to
94073e4
Compare
|
Force Push:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment - I think this is bugged so I'm putting a block on it for now to prevent any accidental merge
94073e4
to
64fae4b
Compare
Now if a value is a secret we will use [redacted] instead of printing the raw value.
64fae4b
to
f3a4054
Compare
|
/backport v22.3.x |
|
/backport v22.2.x |
|
Failed to run cherry-pick command. I executed the below command: |
Now if a value is a secret we will use [redacted] instead of printing the raw value.
Backports Required
Release Notes
Bug Fixes
rpk cluster config import/editNote: already saved properties are not shown.