Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Logger from core module #135

Closed
takahi-i opened this issue Apr 4, 2014 · 1 comment
Closed

Remove Logger from core module #135

takahi-i opened this issue Apr 4, 2014 · 1 comment

Comments

@takahi-i
Copy link
Member

takahi-i commented Apr 4, 2014

For the handy use of document-validator as a library, we remove logger from core module. The errors in core are going to be thrown and caught by the applications.

@jmoriya
Copy link
Contributor

jmoriya commented Apr 20, 2014

I think Logger.error can be replaced as some kind of exception (DocumentValidatorException or standard exception).

And, Logger.warn and Logger.info needs somewhere to need to save if we have to keep their message.
My personal one idea is that DocumentValidator itself provides warn and info.
Does it make sense? Or is it too much?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants