Add arglist metadata to navs. #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll need you to sign a contributor agreement before I can merge this in. Can you send your email to nathan@nathanmarz.com and I'll send it over to you via Adobe Sign? |
|
The code from src/clj/com/rpl/specter.cljc is code that is copied and modified from https://github.com/clojure/clojure/blob/master/src/clj/clojure/core.clj. Should I move that code into a separate commit or pull request? Do I need to rewrite it so it's not derivative from clojure core code? The changes in src/clj/com/rpl/specter/macros.clj are my own. |
|
Is there anything I can do on my end to make progress on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's driving me nuts that none of the navigators have the
:arglistsmetadata.No
:arglistsmetadata means the args for navigators don't pop up in my editor. The arglists also don't show up for my editor's find doc feature or in the repl withclojure.repl/doc.