Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream management support #67

Closed
a-iv opened this issue Feb 5, 2013 · 54 comments
Closed

Stream management support #67

a-iv opened this issue Feb 5, 2013 · 54 comments
Labels
Milestone

Comments

@a-iv
Copy link
Member

@a-iv a-iv commented Feb 5, 2013

@Natanji
Copy link

@Natanji Natanji commented Apr 23, 2013

This would be a very important feature for mobile use to prevent everyone seeing mobile users disconnect/reconnect all the time in quick succession...

@mhellwig
Copy link

@mhellwig mhellwig commented May 29, 2013

is there any info whether this can/will be added and with what sort of timeframe?

mobile XMPP is almost unusable without this.

@JazJazgot
Copy link

@JazJazgot JazJazgot commented Aug 22, 2013

This is really very important

@hillbicks
Copy link

@hillbicks hillbicks commented Oct 14, 2013

Hi everyone,

I’d like to see this as well. Seeing that xabber is a client for android, therefore a primarily mobile client, this is a very important feature. I’m still trying to convince everyone and their mother to use xmpp as an alternative to facebook chats, google hangout and whatnot. But this is still difficult because every once in a while messages get lost when losing the connection. Yes, the little green check mark helps, but not everyone looks for that - constantly. I really think this should be a priority because it prevents people from taking xmpp seriously and using it on a daily basis.

Please don’t see this as a “I’m entitled to that feature, hurry up and programm”, I’m just trying to make the case for reliable message delivery. It would be really nice if you could share your thoughts on this feature. Are you considering it, is there an estimate for this feature, etc.

Thanks very much!

@gjedeer
Copy link

@gjedeer gjedeer commented Oct 20, 2013

So this is why messages are lost sometimes. XEP-198 looks like a must-have on a mobile connection.

@inittab
Copy link

@inittab inittab commented Oct 21, 2013

Hi, please, pretty please, implement this must-have feature on a mobile client. Otherwise messages get silently lost.
Thanks for you work!

@Nekmo
Copy link

@Nekmo Nekmo commented Nov 11, 2013

Another one that loses messages because of this :(

@busybit
Copy link

@busybit busybit commented Jan 2, 2014

When can we expect this "must-have extension" in Xabber?

Does someone know some other Android client with XEP-0198?

@casperklein
Copy link

@casperklein casperklein commented Jan 6, 2014

Securechat, Yaxim and Conversation

@AndreasUfert
Copy link

@AndreasUfert AndreasUfert commented Jan 8, 2014

Would like to see XEP-0198 support in Xabber, too. The need is well-founded described here: http://op-co.de/blog/posts/XEP-0198/

@devurandom
Copy link

@devurandom devurandom commented Jan 23, 2014

Any news or progress in this matter?

@hillbicks
Copy link

@hillbicks hillbicks commented Jan 23, 2014

Since the last update to the development edition of xabber is from september of last year, I'm pretty sure they abandoned this project and it doesn't seem that anyone is working on making xmpp a usable experience for mobile users. Sad state of affairs really.

@ghost
Copy link

@ghost ghost commented Jan 24, 2014

Before August last year there had been a period of 6 months without any updates to the development version, so that's not a guarantee the project was abandoned.

@casperklein
Copy link

@casperklein casperklein commented Jan 30, 2014

According to twitter, they are still working on xabber development: https://twitter.com/Xabber_XMPP/status/428140402529402880

@geramaya
Copy link

@geramaya geramaya commented Jan 30, 2014

pardon, but i don't like twitter. i would like to use github for communication and watch the project :)
thx in advance

@hillbicks
Copy link

@hillbicks hillbicks commented Jan 31, 2014

yaxim now supports xep-0198 and it seems to work just fine! Just switched the client. Version 0.87.

@DrAzraelTod
Copy link

@DrAzraelTod DrAzraelTod commented Feb 21, 2014

+1

@schtobia
Copy link

@schtobia schtobia commented Mar 13, 2014

+1, the single most important missing feature of xabber and the reason I'm with yaxim right now.

@Polve
Copy link

@Polve Polve commented Mar 13, 2014

+1

1 similar comment
@egon0
Copy link

@egon0 egon0 commented Mar 17, 2014

+1

@Finkregh
Copy link

@Finkregh Finkregh commented Mar 17, 2014

what @schtobia said.

:(

@kaimast
Copy link

@kaimast kaimast commented Mar 30, 2014

Would be so nice to see this in Xabber. +1

@kiowas
Copy link

@kiowas kiowas commented Apr 8, 2014

+1

@jplitza
Copy link

@jplitza jplitza commented May 3, 2014

FTR, here is the feature request in Smack, the XMPP library Xabber uses. No activity there for over a year now either, but it contains links to the relevant pull requests in [gibberbot/ChatSecure](which uses Smack as well) and their build system for Smack, aSmack.

@DanScharon
Copy link

@DanScharon DanScharon commented Nov 15, 2014

+1 a must-have, indeed

@tejasinamdar
Copy link

@tejasinamdar tejasinamdar commented Feb 3, 2015

We have developed the plugin to ensure that no messages are lost (in the context of Openfire). Using Openfire, in the presence of a weak network, messages/packets are lost. Hence, to ensure deliveries (at-least-once) and no message/packet losses we have developed the plugin. The plugin ensures 'Stanza Acknowledgements' (the ability to know if messages have been received by one's peers) with no losses (at-least-once deliveries).
See 'https://www.atklique.com/bridge/blog/?q=node/5'.

@andrewnenakhov andrewnenakhov modified the milestones: Unconfirmed Bugs, Unscheduled improvements May 14, 2015
@SafwatHalaby
Copy link

@SafwatHalaby SafwatHalaby commented Sep 25, 2015

@sbrl
Copy link

@sbrl sbrl commented Dec 4, 2015

This is getting really bad. Recently on the mobile network I've just 10% of messages sent / received have got through. I don't want to, but I might have to switch out from Xabber temporarily while this is implemented.

Also, I've noticed that @gjedeer has created a bounty for this issue, which currently stands at $45. Link here.

@schtobia
Copy link

@schtobia schtobia commented Dec 4, 2015

I've thrown in an additional $15 bucks. This issue needs to be done.

@denschub
Copy link
Contributor

@denschub denschub commented Jan 3, 2016

Smack supports stream management since 4.1.0...

@grigoryfedorov grigoryfedorov removed this from the Unscheduled improvements milestone Mar 22, 2016
@Ape
Copy link

@Ape Ape commented Apr 10, 2016

Why is this issue still open if #595 was merged?

@sbrl
Copy link

@sbrl sbrl commented Apr 10, 2016

@Ape Good question. I'll have to try and see if I am dropping any messages now.

@SafwatHalaby
Copy link

@SafwatHalaby SafwatHalaby commented Apr 10, 2016

Note that "Stream Management" alone does not guarantee messages are never dropped. In the case where a client disconnects and stays offline from a while, stream management will timeout. If a message was pending to be sent to said client and such a timeout occurs, then it is up to the server implementation to either notify the sender of an error, or store the message and treat it as a message sent to an offline contact.

The latter behavior is required for a true 100% guarantee of delivery. So pick the right server. Ejabberd optionally supports the latter option via the resend_on_timeout listening module setting.

@sbrl
Copy link

@sbrl sbrl commented Apr 10, 2016

@LogicParrot My server should be configured to support both stream management and storing messages sent to offline contacts. I'll test it when I next get a chance.

@weiss
Copy link

@weiss weiss commented Apr 10, 2016

You don't usually want the server to write such pending messages to offline storage unless you know the recipient wasn't online with a second device which already received those messages (by means of carbon copies, for example). ejabberd's resend_on_timeout option can be set to if_offline which does the right thing™ in most but not all cases. The details are explained in an FAQ entry.

The proper way to ensure reliable delivery (and at the same time, multi-device sync) is to use MAM.

@SafwatHalaby
Copy link

@SafwatHalaby SafwatHalaby commented Apr 11, 2016

Can MAM act as a complete substitute for Carbon Copies and/or Stream Management?

@weiss
Copy link

@weiss weiss commented Apr 11, 2016

No, you want to use carbon copies to synchronize online clients and MAM to let offline clients catch up. You also want to continue using stream management to figure out which outgoing messages must be resent after network outages, and for quick stream resumption.

@denschub
Copy link
Contributor

@denschub denschub commented Apr 29, 2016

@grigoryfedorov do you mind closing this feature request?

@ItchyBugReporter
Copy link

@ItchyBugReporter ItchyBugReporter commented Jul 19, 2016

I say keep it open. It's definitely a must-have for mobile-only users.

@denschub
Copy link
Contributor

@denschub denschub commented Jul 19, 2016

This was implemented in #595 almost 8 months ago.

@ItchyBugReporter
Copy link

@ItchyBugReporter ItchyBugReporter commented Jul 19, 2016

Ah, I didn't realize you've already submitted the code for it. Looks like it just needs to be merged in :-)

@denschub
Copy link
Contributor

@denschub denschub commented Jul 20, 2016

It, uh, was merged 8 months ago. That's the reason I insist on having this issue closed, because this is resovled. :)

@ItchyBugReporter
Copy link

@ItchyBugReporter ItchyBugReporter commented Jul 20, 2016

If it's been merged, then github is lieing to me about the contents of the files you changed. Neither of the files referenced in your pull request have your changes in Redsolution's repository.

@sbrl
Copy link

@sbrl sbrl commented Jul 20, 2016

Just a note: I still appear to be dropping messages in both directions when switching networks on my phone (e.g. 3G <-> WiFi or moving mobile network cells).

@ItchyBugReporter
Copy link

@ItchyBugReporter ItchyBugReporter commented Jul 20, 2016

@denschub Ah, I was looking at the master branch, not the dev branch. Whoops.

@sbrl Since it's been merged into development, I'm guessing you'll need to use the development version of Xabber for the time being if you want to get stream management support.

@sbrl
Copy link

@sbrl sbrl commented Jul 20, 2016

@ItchyBugReporter Right. It'll be in the next beta release then I assume?

@ItchyBugReporter
Copy link

@ItchyBugReporter ItchyBugReporter commented Jul 20, 2016

I'm the wrong person to ask, I'm not a developer for Xabber, and other than this particular thread on the issue tracker I have no communication with the Xabber developers.

I do know that the version on FDroid (which uses the development branch) was built after the merge, so if you're using the FDroid version you probably already have it.

@denschub
Copy link
Contributor

@denschub denschub commented May 3, 2017

@grigoryfedorov please... close this issue. ;)

@sbrl
Copy link

@sbrl sbrl commented May 4, 2017

Ping @a-iv

@andrewnenakhov andrewnenakhov added this to the Xabber 2.0 milestone May 25, 2017
@andrewnenakhov
Copy link
Member

@andrewnenakhov andrewnenakhov commented May 25, 2017

Implemented in v2.0.

@gjedeer
Copy link

@gjedeer gjedeer commented Apr 16, 2020

@andrewnenakhov it seems this is implemented but you did not claim the reward in bountysource, check it out if interested https://www.bountysource.com/issues/1025378-stream-management-support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
You can’t perform that action at this time.