Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow restricting HUD to a parent view. #36

Closed
wants to merge 4 commits into from

Conversation

@patridge
Copy link

@patridge patridge commented Feb 6, 2015

  • Allow a constructor to be called with a parent view that will contain the mask overlay (allowing HUD within a tab, for instance).
  • Figure out a good way to interact the parent view system with the static Show methods.
  • Test that combining Show calls with a parent and without a parent doesn't blow up the world.

(Note: I wasn't sure where to send the PR, but this looked like the in-progress branch so I went for it. I can always cherry-pick it to a master-derived branch, though.)

patridge added 4 commits Feb 6, 2015
Also reverts unneeded Initialize method.
This also allows for "showing" a HUD in a parent view during ViewWillAppear (when Window is potentially null).
@streinhard
Copy link

@streinhard streinhard commented Oct 6, 2016

👍 This would allow usage in Extensions

@Cheesebaron
Copy link
Collaborator

@Cheesebaron Cheesebaron commented Sep 26, 2019

Closing this PR as it is super stale.

@patridge can you maybe outline the idea behind this PR? As far as I understand you want to allow it to show in a specific ViewController, rather than trying to find the current Window and adding it there?

@patridge
Copy link
Author

@patridge patridge commented Sep 26, 2019

Sorry, I definitely don't remember the specifics, and I don't even work where I fist had to make this hack work. I think I was having issues with multiple HUDs and/or across multiple ViewControllers. Or maybe it was when ViewControllers weren't full screen, like the extension example. I really have nothing left in my brain about this, so closing is fine.

@patridge
Copy link
Author

@patridge patridge commented Sep 26, 2019

Actually, seeing this line helped.
https://github.com/redth-org/BTProgressHUD/pull/36/files#diff-94ddb517436bae64cf7f87eb485d3c15R859

// Make sure we account for parent size changing (e.g., TabBar/StatusBar auto-adjustments).

Maybe it was something as simple as limiting the HUD to the tab within a tab controller so that other tabs could still be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants