New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implicit return-type error during typescript compilation #96

Closed
KyleCartmell opened this Issue Aug 16, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@KyleCartmell

KyleCartmell commented Aug 16, 2016

When I try to compile my typescript project which uses redux-observable, the following error messages result:

node_modules/redux-observable/index.d.ts(7,3): error TS7010: 'lift', which lacks return-type annotation, implicitly has an 'any' return type.
node_modules/redux-observable/index.d.ts(8,3): error TS7010: 'ofType', which lacks return-type annotation, implicitly has an 'any' return type.

@KyleCartmell

This comment has been minimized.

KyleCartmell commented Aug 16, 2016

#97

@jayphelps

This comment has been minimized.

Member

jayphelps commented Aug 16, 2016

I read #97 and I'm not sure what the status of these two are.

Is there still a problem? could you summarize what the issue is? I see several things mentioned and that PR closed so it's not clear what the issue truly is.

@KyleCartmell

This comment has been minimized.

KyleCartmell commented Aug 16, 2016

Issue above persists. When I compile a TypeScript project which uses redux-observable tsc complains about implicit 'any' return types. Adding return type information to the typings file exposed by redux-observable resolves the error. The PR I submitted did the needful but used the wrong types. I see your comment in the PR comments stating that ActionsObservable is the correct type, even for ofType. I'll happily open a new PR with the correct types if you feel that this issue is clear and that the types are desirable.

@jayphelps jayphelps closed this in 95b4ce4 Aug 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment