Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): adds store type to Epic #174

Merged
merged 1 commit into from Jan 20, 2017

Conversation

@billba
Copy link
Contributor

@billba billba commented Jan 19, 2017

Closes #172

Also includes a couple of TypeScript-related fixes:

  • redux now includes its own types, so @types/redux isn’t needed
  • typings.json isn’t used anymore
@jayphelps
Copy link
Member

@jayphelps jayphelps commented Jan 19, 2017

code looks good, needs conventional-changelog formatted commit message https://github.com/redux-observable/redux-observable/blob/master/CONTRIBUTING.md#sending-a-pull-request

@billba
Copy link
Contributor Author

@billba billba commented Jan 19, 2017

Okay I will look and learn.

@billba billba changed the title Implements #172 fix(typescript): adds store type to Epic Jan 20, 2017
@billba
Copy link
Contributor Author

@billba billba commented Jan 20, 2017

Better?

@jayphelps jayphelps merged commit ca4b163 into redux-observable:master Jan 20, 2017
1 check passed
@jayphelps
Copy link
Member

@jayphelps jayphelps commented Jan 20, 2017

@billba You actually only changed the ticket's title, not the commit message. I fixed it for you when I merged: ca4b163

Published as 0.13.0, thanks for your help! 🎉

@billba
Copy link
Contributor Author

@billba billba commented Jan 20, 2017

Aha! How do I change a commit message?

@jayphelps
Copy link
Member

@jayphelps jayphelps commented Jan 20, 2017

https://help.github.com/articles/changing-a-commit-message/#amending-older-or-multiple-commit-messages

Btw--Is says editing older commits is discouraged, but it fails to clarify that they mean discouraged in public branches that people depend on. It's very normal and common to force push against a PR branch. e.g. making code changes (people often ask authors "squash" their commits") or changing the commit message. So don't be scared 😄

@billba
Copy link
Contributor Author

@billba billba commented Jan 20, 2017

Thank you for googling that for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants