Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dependencies): Loosen peerDependencies #359

Merged
merged 1 commit into from Nov 30, 2017

Conversation

@mrmckeb
Copy link
Contributor

commented Nov 12, 2017

A PR to loosen the peerDependencies in redux-observable. See #358 for further details.

Closes #358.

@jayphelps

This comment has been minimized.

Copy link
Member

commented Nov 28, 2017

thanks for the PR! can you clarify under what circumstances this allows that weren't before? #358 doesn't clarify. I'm guessing prerelease/beta versions of rxjs right?

@mrmckeb

This comment has been minimized.

Copy link
Contributor Author

commented Nov 29, 2017

Update: It appears that the root cause of this may actually be bug in Yarn, and this fix may not be needed. See: yarnpkg/yarn#4850.

Apologies, I was trying to be a good citizen by contributing a fix rather than just complaining about an issue - but this may not be needed. However, it may be worth merging anyway as it allows pre-release versions and standardises the two peer dependencies.


Hi @jayphelps, thanks for getting back to me.

When using redux-observable (0.17.0), we're receiving warnings in Yarn about unmet peer dependencies.

warning redux-observable@0.17.0" has unmet peer dependency "redux@3.*".
warning redux-observable@0.17.0" has unmet peer dependency "rxjs@^5.0.0".

This project's package.json has:

...
"redux": "^3.7.2",
"rxjs": "^5.5.2",
"redux-observable": "^0.17.0",
...

I understand that the current implementation is as per the npm semver docs, but for whatever reason this does not seem to be working with Yarn.

This PR aims to resolve that by defining a range that is more expressive using primitive range syntax, and as also less strict around beta versions.

@jayphelps jayphelps merged commit 3140ac2 into redux-observable:master Nov 30, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jayphelps

This comment has been minimized.

Copy link
Member

commented Nov 30, 2017

@mrmckeb thanks for the explanation, that makes sense. But you're right about it not previously allowing beta/alpha/etc so I'm thankful for this PR! Thank you!

@mrmckeb mrmckeb deleted the mrmckeb:patch-3 branch Dec 1, 2017

@mrmckeb

This comment has been minimized.

Copy link
Contributor Author

commented Dec 1, 2017

Thanks @jayphelps, and great work on this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.