Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign uptypings: make lettable ofType properly narrow action type #385
Conversation
Hotell
changed the title
typings: make lettable ofType properly type narrow
typings: make lettable ofType properly narrow action type
Dec 25, 2017
jayphelps
reviewed
Jan 4, 2018
index.d.ts
Outdated
| @@ -52,6 +52,6 @@ export declare function createEpicMiddleware<T extends Action, S, D = any>(rootE | |||
| export declare function combineEpics<T extends Action, S, D = any>(...epics: Epic<T, S, D>[]): Epic<T, S, D>; | |||
| export declare function combineEpics<E>(...epics: E[]): E; | |||
|
|
|||
| export declare function ofType<T extends Action>(...keys: T['type'][]): (source: Observable<T>) => Observable<T>; | |||
| export declare function ofType<T extends Action, R extends T, K extends R['type'] = R['type']>(...key: K[]): (source: Observable<T>) => Observable<R>; | |||
This comment has been minimized.
This comment has been minimized.
jayphelps
Jan 4, 2018
Member
I believe this would be a breaking change since it now requires two params instead of one. But if we provide a default param for the second one I think that would make it non-breaking and have the same behavior as before wouldn't it? R extends T = T
ofType<T extends Action, R extends T = T, K extends R['type'] = R['type']>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Thank you for this! Let's discuss my breaking change comment a bit. Also, I kicked the build as it failed for unrelated reasons and should pass now, assuming it would otherwise. |
Hotell
force-pushed the
Hotell:ts-ofType
branch
from
016e4a0
to
b1ed9fa
Jan 16, 2018
Hotell
force-pushed the
Hotell:ts-ofType
branch
from
b1ed9fa
to
94378aa
Jan 16, 2018
This comment has been minimized.
This comment has been minimized.
|
hey @jayphelps sorry it took so long :( too busy lately
thx! |
jayphelps
merged commit 45d09a7
into
redux-observable:master
Jan 17, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
Thanks again! |
Hotell
deleted the
Hotell:ts-ofType
branch
Jan 17, 2018
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
eemelisoderholm
referenced this pull request
Feb 23, 2018
Closed
Could typeOf narrowing work without explicit generics in TypeScript 2.8? #437
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Hotell commentedDec 25, 2017
•
edited
I have read the Contributor Guide
My commit messages are in conventional-changelog-standard format.
adds Typescript docs to troubleshooting
enables strict mode for TS test
covers proper type narrowing within TS tests
Closes #382