New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typings): Update type of Epic to add state$ #465

Merged
merged 2 commits into from Apr 5, 2018

Conversation

Projects
None yet
3 participants
@cjol
Contributor

cjol commented Apr 5, 2018

I had to add this to use it in my own project, so I figured I would share.

export declare interface Epic<T extends Action, S, D = any, O extends T = T> {
(action$: ActionsObservable<T>, store: MiddlewareAPI<S>, dependencies: D): Observable<O>;

This comment has been minimized.

@jayphelps

jayphelps Apr 5, 2018

Member

Can you rename the parameter to state$?

This comment has been minimized.

@jayphelps

jayphelps Apr 5, 2018

Member

I tried making this change myself but it looks like you don't have the option checked to "allow edits from maintainers". https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/

This comment has been minimized.

@cjol

cjol Apr 5, 2018

Contributor

Hm, that's strange - I think that option is enabled so I wonder if there is another issue. First pull request so I'm on unfamiliar ground!

Anyway, I think this is now fixed.

This comment has been minimized.

@jayphelps

jayphelps Apr 5, 2018

Member

Yay! thanks for the quick fix. And SUPER thanks for the PR!

I'm not sure either what the issue is either, sorry bout that. < 3

This comment has been minimized.

@ajcrites

ajcrites Apr 6, 2018

Contributor

This change doesn't remove the import of MiddlewareAPI which is no longer used.

@jayphelps

This comment has been minimized.

Member

jayphelps commented Apr 5, 2018

Thank you!! Just the minor param rename and this looks good.

@jayphelps jayphelps merged commit 6e9430d into redux-observable:master Apr 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jayphelps

This comment has been minimized.

Member

jayphelps commented Apr 5, 2018

Thanks again! released as 1.0.0-alpha.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment