Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combined function name #480

Merged
merged 1 commit into from May 9, 2018
Merged

Combined function name #480

merged 1 commit into from May 9, 2018

Conversation

@Bamieh
Copy link
Contributor

@Bamieh Bamieh commented Apr 19, 2018

Combined functions always return <anonymous> which is not very useful. This Commit updates the name of the combined epics to the following:

combineEpics(epic1, epic2)

@Bamieh Bamieh force-pushed the patch-1 branch 3 times, most recently from 34aeb31 to d596df7 Apr 19, 2018
@jayphelps
Copy link
Member

@jayphelps jayphelps commented Apr 25, 2018

This is SWEET and clever! THANK YOU! Could you possibly include a simple test that confirms it works as expected?

Combined functions always return `<anonymous>` which is not very useful. This Commit updates the name of the combined epics to the following:

> combineEpics(epic1, epic2)

style(combineEpics): shorter code

style(combineEpics): fix linting

fallback to '<anonymous>'

add unit tests
@Bamieh
Copy link
Contributor Author

@Bamieh Bamieh commented Apr 26, 2018

@jayphelps Yay 🎉 I added 3 unit tests.

@jayphelps jayphelps merged commit 816a916 into redux-observable:master May 9, 2018
1 check passed
@jayphelps
Copy link
Member

@jayphelps jayphelps commented May 9, 2018

Thanks again @Bamieh !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants