Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(redux): Upgrade to redux v4 #501

Merged
merged 1 commit into from May 31, 2018
Merged

feat(redux): Upgrade to redux v4 #501

merged 1 commit into from May 31, 2018

Conversation

@evertbouw
Copy link
Member

@evertbouw evertbouw commented May 24, 2018

Bumped version number and fixed tests

@evertbouw evertbouw requested a review from jayphelps May 24, 2018
@evertbouw evertbouw mentioned this pull request May 25, 2018
@@ -0,0 +1 @@
export const initAction: { type: string };
Copy link
Contributor

@Ailrun Ailrun May 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to change this string into more specific one?
I'm afraid that this would mess up some union type like

// Following will be just a string
type actionType = (myAction1 | myAction2 | initAction)['type'];

Copy link
Contributor

@Ailrun Ailrun May 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry. It's just for the test. My mistake.

@tcozzens
Copy link

@tcozzens tcozzens commented May 31, 2018

This would be great!

@jayphelps jayphelps merged commit 43c2033 into redux-observable:master May 31, 2018
1 check passed
@jayphelps
Copy link
Member

@jayphelps jayphelps commented May 31, 2018

I changed the commit to be a feat() and added a BREAKING CHANGE block, both so that it shows up in the generated CHANGELOG

@jayphelps jayphelps changed the title chore(redux): Finalize Redux 4 support feat(redux): Upgrade to redux v4 May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants