New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TypeScript type definition): Add combineEpics(), provide more accurate type info for others #70

Merged
merged 1 commit into from Jul 14, 2016

Conversation

Projects
None yet
2 participants
@jayphelps
Member

jayphelps commented Jul 14, 2016

fixes #69

@vire if you get a chance, could you confirm these new typings are good? I don't have any apps that use both TS and redux-observable yet. (though we do have a basic test of the typings included)

// ./node_modules/rxjs/Observable.d.ts specifies operators as generics like so
// `protected operator: Operator<any, T>;`
lift(operator: Operator<any, T>);
export declare function createEpicMiddleware(...epics: Epic[]): Middleware;

This comment has been minimized.

@vire

vire Jul 14, 2016

Contributor

I'm a bit unsure about the spread epics here, I thought createEpicMiddleware takes just 1 epic (as result of combineEpics) if there are multiple like createEpicMiddleware(epic1, epic2, epic3) the epic2 and epic3 are just ignored?

This comment has been minimized.

@jayphelps

jayphelps Jul 14, 2016

Member

Whoops, missed this comment. You're totally right. Going to correct it for a future release.

@vire

This comment has been minimized.

Contributor

vire commented Jul 14, 2016

I've updated my typings definiton from this PR and it works fine.

@jayphelps

This comment has been minimized.

Member

jayphelps commented Jul 14, 2016

@vire Thanks for confirming!

@jayphelps jayphelps merged commit 20da88c into master Jul 14, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jayphelps

This comment has been minimized.

Member

jayphelps commented Jul 14, 2016

@vire released as 0.7.1

@jayphelps jayphelps deleted the typings branch Aug 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment