memoize renderedWrappedComponent separately to prevent this step from… #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-redux-docs ready! Built with commit 89afbec |
… being performed when redundant
|
initial https://github.com/reduxjs/react-redux-benchmarks results:
|
timdorr
approved these changes
Apr 12, 2019
|
Thanks. Given that there's a few other things that have popped up too, I'd like to investigate a bit further over the weekend before pushing out a new release. |
|
Well, I'm going to merge this in now. |
This was referenced Oct 26, 2019
webguru7
pushed a commit
to webguru7/react-redux
that referenced
this pull request
Dec 8, 2022
… being performed when redundant (reduxjs#1234)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the following issue in my @welldone-software/why-did-you-render library:
welldone-software/why-did-you-render#18
discovered a small performance improvement possibility:
WrappedComponentshould not be re-created for every state change. Instead it can be memoized separately.