Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memoize renderedWrappedComponent separately to prevent this step from… #1234

Merged

Conversation

@vzaidman
Copy link
Contributor

@vzaidman vzaidman commented Apr 12, 2019

the following issue in my @welldone-software/why-did-you-render library:
welldone-software/why-did-you-render#18
discovered a small performance improvement possibility:

WrappedComponent should not be re-created for every state change. Instead it can be memoized separately.

@netlify
Copy link

@netlify netlify bot commented Apr 12, 2019

Deploy preview for react-redux-docs ready!

Built with commit 89afbec

https://deploy-preview-1234--react-redux-docs.netlify.com

@vzaidman vzaidman force-pushed the separate-wrapped-component-memoization branch from 453ae85 to 89afbec Apr 12, 2019
@vzaidman
Copy link
Contributor Author

@vzaidman vzaidman commented Apr 12, 2019

@markerikson
Copy link
Contributor

@markerikson markerikson commented Apr 12, 2019

Thanks. Given that there's a few other things that have popped up too, I'd like to investigate a bit further over the weekend before pushing out a new release.

@timdorr
Copy link
Member

@timdorr timdorr commented Apr 12, 2019

Well, I'm going to merge this in now.

@timdorr timdorr merged commit 8719eda into reduxjs:master Apr 12, 2019
7 checks passed
@vzaidman vzaidman deleted the separate-wrapped-component-memoization branch Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants