Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memoize renderedWrappedComponent separately to prevent this step from… #1234

Merged

Conversation

@vzaidman
Copy link
Contributor

commented Apr 12, 2019

the following issue in my @welldone-software/why-did-you-render library:
welldone-software/why-did-you-render#18
discovered a small performance improvement possibility:

WrappedComponent should not be re-created for every state change. Instead it can be memoized separately.

@netlify

This comment has been minimized.

Copy link

commented Apr 12, 2019

Deploy preview for react-redux-docs ready!

Built with commit 89afbec

https://deploy-preview-1234--react-redux-docs.netlify.com

@vzaidman vzaidman force-pushed the vzaidman:separate-wrapped-component-memoization branch from 453ae85 to 89afbec Apr 12, 2019

@vzaidman

This comment has been minimized.

Copy link
Contributor Author

commented Apr 12, 2019

@markerikson

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

Thanks. Given that there's a few other things that have popped up too, I'd like to investigate a bit further over the weekend before pushing out a new release.

@timdorr

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

Well, I'm going to merge this in now.

@timdorr timdorr merged commit 8719eda into reduxjs:master Apr 12, 2019

5 of 7 checks passed

Header rules - react-redux-docs No header rules processed
Details
Pages changed - react-redux-docs All files already uploaded
Details
Mixed content - react-redux-docs No mixed content detected
Details
Redirect rules - react-redux-docs 5 redirect rules processed
Details
codecov/project 97.75% (+<.01%) compared to 7402f72
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/react-redux-docs/deploy-preview Deploy preview ready!
Details

@vzaidman vzaidman deleted the vzaidman:separate-wrapped-component-memoization branch Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.