add a line to insist on the pure nature #1386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a line to insist on the pure nature of mapStateToProps function
|
Deploy preview for react-redux-docs ready! Built with commit 4bd70e0 |
Member
|
I integrated it into an existing sentence so it doesn't add so much to the original content. Thanks for the starting point! |
aminsoheyli
commented
Aug 27, 2019
Contributor
Author
aminsoheyli
left a comment
aminsoheyli
left a comment
There was a problem hiding this comment.
That's a great reordering.
Thanks!
| ### `mapStateToProps` Functions Should Be Pure and Synchronous | ||
| Much like a Redux reducer, a `mapStateToProps` function should always be 100% pure and synchronous. It should simply take `state` (and `ownProps`) as arguments, and return the data the component needs as props. It should _not_ be used to trigger asynchronous behavior like AJAX calls for data fetching, and the functions should not be declared as `async`. Also it should not mutate the `state` or the `ownProps`. | ||
| Much like a Redux reducer, a `mapStateToProps` function should always be 100% pure and synchronous. It should only take `state` (and `ownProps`) as arguments, and return the data the component needs as props without mutating those arguments. It should _not_ be used to trigger asynchronous behavior like AJAX calls for data fetching, and the functions should not be declared as `async`. |
albertodev7
pushed a commit
to albertodev7/react-redux
that referenced
this pull request
Dec 8, 2022
* add a line to insist on the pure nature add a line to insist on the pure nature of mapStateToProps function * Reorder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a line to insist on the pure nature of mapStateToProps function