Set displayName explicitly on Provider #506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can you make this against the next branch? master isn't likely to get another release and it would be good to have in the upcoming 5.0 release. |
Contributor
Author
|
@timdorr done! |
Member
|
Thanks! |
aikoven
pushed a commit
to aikoven/react-redux
that referenced
this pull request
Nov 21, 2016
neeharv
pushed a commit
to neeharv/react-redux
that referenced
this pull request
Feb 18, 2017
albertodev7
pushed a commit
to albertodev7/react-redux
that referenced
this pull request
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When code gets uglified for production builds, original names of identifiers gets lots and React components show up with their uglified name. To remedy this,
displayNamecan be set explicitly.For
React.createClassstyle components, displayName gets automatically set by babel.React components declared using ES6-classes however, have mangled names. This is the case for
Provider. With this PR, the name is explicitly set which should make the name survive the uglification process.