Enforce shape of store property #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This produce better Error messages, when store property is not being provided. In our case we migrated to redux-1.0.x and got the waring: "Warning: Failed Context Types: Required child context `store` was not specified in `Provider`" because previously the property holding the flux instance was named redux. With the propTypes specified you would get the following warning: "Warning: Failed propType: Required prop `store` was not specified in `Provider`" which makes it pretty clear how and where to fix the issue.
gaearon
added a commit
that referenced
this pull request
Aug 18, 2015
Enforce shape of store property
Contributor
|
Thanks. Somehow I lost it while refactoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This produce better Error messages, when store property is not being provided.
In our case we migrated to redux-1.0.x and got the waring:
because previously the property holding the flux instance was named redux.
With the propTypes specified you would get the following warning:
which makes it pretty clear how and where to fix the issue.