Fix some typos and inconsistencies in documentation #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
Contributor
There was a problem hiding this comment.
We'd rather not use ES7 experimental code in examples to avoid confusing beginners.
Contributor
Author
There was a problem hiding this comment.
There are several other instances of object spread notation in the README, both in the text and in the examples. If you want, I can revert them all back to Object.assign.
Contributor
Author
There was a problem hiding this comment.
Hmm, in fact there were only the two that I introduced and two more.
Contributor
There was a problem hiding this comment.
Yeah, I'd prefer to use assign everywhere.
gaearon
added a commit
that referenced
this pull request
Aug 21, 2015
Fix some typos and inconsistencies in documentation
Contributor
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.