Skip to content

Conversation

@EskiMojo14
Copy link
Contributor

@EskiMojo14 EskiMojo14 commented Oct 8, 2024

fixes #183

Redux Mock Store still has a lot of usage in the ecosystem, but the Redux team believes there are better approaches to testing a store. Similar to our deprecation of createStore, deprecating this package/function will reach people who may not have seen our updated testing guidance.

A legacy_configureStore export without the deprecation notice is available.

The JSDoc will also need updating over on the DefinitelyTyped side, but we'll do that once we've agreed how to do it here.

@EskiMojo14
Copy link
Contributor Author

Hi @arnaudbenard @dmitry-zaets :)

Would either of you be able and willing to add me as a maintainer to the npm package? My npm username is eskimojo. (you should be able to see me as a member of the @reduxjs org)

Happy to discuss this deprecation with either of you if you have any concerns!

cc @jednano as your fork has some traction 👋🏻

@EskiMojo14 EskiMojo14 changed the title Add deprecation notice to README Add deprecation notice to README and JSDoc Oct 8, 2024
@dmitry-zaets
Copy link
Collaborator

dmitry-zaets commented Oct 15, 2024

hi @EskiMojo14.
Sure, makes sense. Let's proceed with this.
Could you please re-format PR to follow the same rules for the code as it was following? (Single quotes and no ';' in the end of line)

@EskiMojo14
Copy link
Contributor Author

@dmitry-zaets sure - I've added a quick prettier config for people (like myself) who have auto formatting on save.

@dmitry-zaets dmitry-zaets merged commit 8c1b40a into master Oct 18, 2024
@EskiMojo14 EskiMojo14 deleted the deprecate branch October 18, 2024 15:04
@dmitry-zaets
Copy link
Collaborator

@EskiMojo14 Added you as a maintained to the npm package. Feel free to publish a new version

@EskiMojo14
Copy link
Contributor Author

EskiMojo14 commented Oct 21, 2024

@dmitry-zaets published as 1.5.5, thank you! I'll get a release note written up soon.

edit - https://github.com/reduxjs/redux-mock-store/releases/tag/v1.5.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add note that this is no longer recommended or maintained?

4 participants