add endpoint, type and forced to BaseQueryApi and prepareHeaders
#1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phryneas
commented
Oct 26, 2021
| (Number(new Date()) - Number(fulfilledVal)) / 1000 >= refetchVal | ||
| ) | ||
| } | ||
| if (fulfilledVal) |
There was a problem hiding this comment.
I moved that out to also be able to call it elsewhere. Could someone (@msutkowski you were working on this with me?) please verify that I didn't break the logic?
msutkowski
reviewed
Oct 26, 2021
This was referenced Oct 27, 2021
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 09e4306:
|
phryneas
commented
Oct 28, 2021
| @@ -71,36 +72,27 @@ const authSlice = createSlice({ | |||
| const storeRef = setupApiStore(api, { auth: authSlice.reducer }) | |||
| type RootState = ReturnType<typeof storeRef.store.getState> | |||
|
|
|||
| const defaultBaseQueryApi: BaseQueryApi = { | |||
There was a problem hiding this comment.
This needs to be a callback, as otherwise all tests will refer storeRef.store from before the first test as the stale reference will not pick up the store replacement between tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still needs tests & adjustments for existing tests.
It should unlock quite some behavior around
Cache-Controlheaders.